feat: cli core checker #4687
Open
feat: cli core checker #4687
+181
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeno097
requested review from
jmrossy,
yorhodes,
ltyu and
paulbalaji
as code owners
🦋 Changeset detectedLatest commit: 47af3b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…guration and on chain deployments. Adds memoization to the EvmHookReader to avoid repeating configuration derivation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new
core checkcommand to allow comparing local core contract configuration with the on chain deployment and detect mismatches.Examples:
Drive-by changes
DEFAULT_CORE_DEPLOYMENT_CONFIG_PATHto remove repeated and hardcoded './configs/core-config.yaml' stringsexecuteCoreReadfunction to reuse it in thecore checkcommand logic.EvmHookReaderbecause reading on chain configuration for chains likearbitrum,ethereumoroptimismwas taking more than 10 minutes to complete due to repeated hook config retrievalRelated issues
Backward compatibility
Testing
Notes